kobotoolbox / kpi / 23344806450

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

perf(openrosa): reduce SQL queries on formList and manifest endpoints DEV-1841 (#6844)

### Summary

The formList, manifest, and related OpenRosa endpoints were making
unnecessary and repeated database queries on every request from a mobile
data collection device.

### Description

Each time a mobile device (e.g. KoboCollect) requested the list of
available forms, the server was doing far more work than needed: loading
massive amounts of data it did not use, repeating the same lookups once
per form, and running extra sort operations that served no purpose.

This fix makes the server load only what it strictly needs and avoids
repeating the same lookups in a loop. On large deployments with many
forms or media files, this translates into noticeably faster responses.

Run Details

7432 of 11542 branches covered (64.39%)

22 of 57 new or added lines in 5 files covered. (38.6%)

2 existing lines in 2 files now uncovered.

28543 of 34901 relevant lines covered (81.78%)

5.81 hits per line