agama-project / agama / 23320153694

77%

push

github

Fix network configuration (#3306)

This PR fixes two problems with network configuration.

## Importing connection ids from AutoYaST

When importing an AutoYaST interface that does not have a `name`, Agama
leaves sets the `id` to an empty string, which is an invalid id.
This patch fallsback to using the `device` if the `name` is empty.

## SetConfig should not fail when network configuration fails

Similarly to what happened with scripts/files, the `SetConfig` action
stops when there is a network configuration error. This PR
modifies this behavior to just log the error and continue.

## Follow-up

- Report configuration errors from the `agama-network` service.
- We need to make sure that none of the services returns an error in
`SetConfig`. The only valid error in those cases are actors
communication problems.
  Any other error should be handled by the service. It could:

  1. Notify the user.
  2. Just log the problem.
  3. Register an issue.

3251 of 5221 branches covered (62.27%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

20649 of 25845 relevant lines covered (79.9%)

86.03 hits per line