decentraland / social-service-ea / 23319900821

90%

main: 90%

Pull #405

github

fix: walk full referral chain to detect banned ancestors

The previous ban chain detection only checked 1 level up (the immediate
parent referrer). If an intermediate referrer was not in the DB, or
the banned wallet was 2+ hops away, the check would pass.

Changes:
- Walk up the referral chain up to MAX_CHAIN_DEPTH (5) levels
- Check each ancestor against the deny list
- Detect and break out of circular referral chains
- Gracefully handle missing intermediate records (chain ends at gap)

This prevents the bypass scenario where:
  Banned → A (not in DB) → B → C would pass the old 1-level check

Test cases added for:
- Multi-hop banned chain detection (3 hops)
- Missing intermediate record (chain breaks, referral allowed)
- Circular chain detection (loop broken, referral allowed)

Closes #401

2213 of 2592 branches covered (85.38%)

Branch coverage included in aggregate %.

14 of 14 new or added lines in 1 file covered. (100.0%)

5440 of 5893 relevant lines covered (92.31%)

71.99 hits per line