JuliaLang / julia / 1477

78%

push

buildkite

Escape `@nospecialize` macro output (#61362)

`@nospecialize` and `@specialize` refer to names passed as macro
arguments, so
should theoretically escape them in their expansion. They currently work
without escaping because macroexpand.scm makes a special case for
`:meta` forms.
Unfortunately, that special handling escapes `:meta` too aggressively:

```
julia> macro mac(x); x; end
@mac (macro with 1 method)

julia> ex = @macroexpand @mac function f(@nospecialize(a))
                  a
              end
:(function Main.f($(Expr(:meta, :nospecialize, :a)))
      #= REPL[2]:1 =#
      #= REPL[2]:2 =#
      var"#2#a"
  end)

julia> func = @mac function f(@nospecialize(a))
                  a
              end
f (generic function with 1 method)

julia> func(1)
ERROR: UndefVarError: `#3#a` not defined in `Main`
```

This PR doesn't fix the above or change any current behaviour, but at
least
ensures that JuliaLowering doesn't need to introduce the same bug. There
are
alternatives if this doesn't work, but all would be hacky.

2 of 2 new or added lines in 1 file covered. (100.0%)

64434 of 83125 relevant lines covered (77.51%)

23402658.83 hits per line