kobotoolbox / kpi / 23268748491

82%

master: 76%

push

github

refactor(assetQuickActions): migrate out of allAssets DEV-1319 (#6814)

### 💭 Notes

Changes here:
- Fixed a tiny bug when unarchiving project from Landing page - on main
page wasn't getting fresh asset (after unarchiving it appeared as
nothing happened)
- Removed few `mixins.dmix` functions as mixins are bad and we want to
get rid of them, and they were just proxies of functions from
`assetQuickActions`
- `cloneAsTemplate` removed in favor of using `cloneAssetAsTemplate`
directly
  - `deployAsset` removed in favor of using `deployAsset` directly
  - `archiveAsset` same story
  - `unarchiveAsset` same story
  - `deleteAsset` same story
- In `assetQuickActions` few functions that were operating on
`assetOrUid` are now strictly requiring asset object to be passed (and
thus removing `allAssets` usage from the file). The functions are:
  - `deleteAsset`
  - `archiveAsset`
  - `unarchiveAsset`
  - `cloneAsset`
- `AssetActionButtons` is using `deployAsset` directly from
`assetQuickActions` instead of relying on (now removed) `mixins.dmix`
function
- This is a component that is being used by `AssetsTable` (the table of
assets rendered at My Library, Public Collections and single collection
routes) and by `AssetRoute` (the single library item route)
- Given above, the deploy button functionality is completely unused (no
`survey` type asset is ever being used with `AssetActionButtons`, but
removing that is out of scope of this PR (my decision)
- `FormLanding` (Project → Form tab component) is now using:
- `unarchiveAsset` from `assetQuickActions` and passing it's own state
(asset object is merged into state through `mixins.dmix`)
- `deployAsset` from `assetQuickActions` and passing it's own state
(asset object is merged into state through `mixins.dmix`)
  - `cloneAssetAsTemplate` from `assetQuickActions`
- `ProjectSettings` (Project → Settings → General tab component) is now
using:
- `deleteAsset` from `assetQuickActions` and passing asset object
instead of ui... (continued)

7614 of 11769 branches covered (64.7%)

29219 of 35603 relevant lines covered (82.07%)

5.8 hits per line