f-dangel / curvlinops / 23264802918

91%

push

github

[REF] Extract `_BaseKFACComputer` to eliminate diamond inheritance (#272)

* [REF] Extract _BaseKFACComputer to eliminate diamond inheritance

Split KFACComputer into:
- _BaseKFACComputer in computers/_base.py: shared logic (validation,
  seed, fisher_type, grad_outputs_computer, compute(), utility methods,
  abstract _compute_kronecker_factors)
- HooksKFACComputer in computers/kfac_hooks.py: hooks-specific code
  (compute_parameter_groups, hook methods, _compute_loss_and_backward)

MakeFxKFACComputer now inherits from _BaseKFACComputer directly.
MakeFxEKFACComputer inherits from MakeFxKFACComputer only (no diamond).

Rename EKFACComputer -> HooksEKFACComputer, move to ekfac_hooks.py.
Remove HooksKFACComputer.__init__ (compute _mapping lazily in
_compute_kronecker_factors).

Before: MakeFxEKFACComputer(EKFACComputer, MakeFxKFACComputer) — diamond
After:  MakeFxEKFACComputer(MakeFxKFACComputer) — clean chain

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [DOC] Add changelog entry for _BaseKFACComputer extraction

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: f-dangel <felix.dangel@concordia.ca>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

195 of 205 new or added lines in 7 files covered. (95.12%)

2356 of 2580 relevant lines covered (91.32%)

0.91 hits per line