FAIRmat-NFDI / nomad-simulations / 23252796048

84%

develop: 83%

Build Type

Pull #260

github

Committed by ndaelman-hu

Commit Message

Improve convergence target documentation and type signatures

- Update base class docstring to explain workflow contexts (SCF and nested workflows)
- Simplify child class docstrings to focus on physical properties rather than workflow types
- Add type signatures to `_preprocess_convergence_value()` method
- Add logger parameter to `_preprocess_convergence_value()` for consistency
- Parameterize relative convergence zero threshold as `relative_zero_epsilon` class attribute
- Fix typo in base class docstring ("todefine" → "to define")

Pull Request Pull Request #260: Refactor SCF quantites and convergence

Coverage Stats

684 of 779 new or added lines in 12 files covered. (87.8%)

46 existing lines in 2 files now uncovered.

8036 of 9634 relevant lines covered (83.41%)

2.5 hits per line