stillwater-sc / universal / 23249391530

85%

master: 84%

push

github

fix(cmake): Fix GCC build on Intel macOS (build failure, warnings, and small-angle std::cos(float) issue) (#591)

* [Codex] Fix build failure on GCC on intel macOS

* [Codex] Fixed macOS on intel GCC warnings

It found the following bits of related technical debt to review later:
  * include/sw/universal/number/unum2/unum2_impl.hpp:412: mixed-domain shift_count
  * include/sw/universal/number/unum2/lattice.hpp:122: suspicious pre-existing _N >> 1 vs _N_half / _N_half logic

* [Codex] Generalized std::cos(float) to fix rounding of small inputs to zero on intel.

* [ChatGPT] better comments and variable names

---------

Signed-off-by: Theodore Omtzigt <theo@stillwater-sc.com>
Co-authored-by: Theodore Omtzigt <theo@stillwater-sc.com>

29 of 30 new or added lines in 3 files covered. (96.67%)

44227 of 52446 relevant lines covered (84.33%)

6000151.44 hits per line