kobotoolbox / kpi / 23247771128

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

fix(admin): prevent manual username changes for existing users in Django admin DEV-1888 (#6839)

### 📣 Summary
This PR locks down the `username` field in the Django admin panel for
existing users, preventing superusers from manually changing it and
breaking the `_userform_id` mapping in MongoDB.

### 📖 Description
Manually changing a username via the Django admin updates the relational
database but leaves MongoDB documents out of sync. Because the
`_userform_id` key in MongoDB relies on the original username, altering
it breaks submission retrieval and detaches submissions from their
correct projects.

Changes:
- Overrides get_readonly_fields in ExtendedUserAdmin (extend_user.py)
- Keeps username editable when creating a new user (obj=None).
- Dynamically appends username to `readonly_fields` when editing an
existing user record.

Run Details

7410 of 11511 branches covered (64.37%)

1 of 5 new or added lines in 1 file covered. (20.0%)

162 existing lines in 7 files now uncovered.

28502 of 34843 relevant lines covered (81.8%)

5.81 hits per line