stillwater-sc / universal / 23203718673

85%

master: 84%

push

github

feat(blas): implement client-directed type registry for serialization (#587)

* feat(blas): implement client-directed type registry for serialization

Replace the framework-enumerates-all-types pattern with a compile-time
type registry where the client declares its supported types:

  using MyTypes = type_list<float, double, half>;
  typed_datafile<MyTypes> df;
  df.restore(stream);  // only instantiates float, double, half

New files:
- type_registry.hpp: type_list<>, dispatch<>, try_match<> using
  fold expressions for compile-time generated type matching
- typed_datafile.hpp: typed_datafile<TypeList> class that uses the
  registry for restore dispatch; save is type-erased via ICollection

Extended datafile.hpp:
- Added type IDs for posit v2, dd, qd
- Added type names to scalarType() for new types

Test suite (typed_serialization.cpp):
- Float/double/half vector round-trip
- Type mismatch (graceful error when type not in registry)
- Multiple datasets in one file

Resolves #583

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(blas): address CodeRabbit review on typed_datafile

1. Fix memory leak (critical): restore path used raw new without
   delete. Add OwnedCollectionContainer that holds a unique_ptr
   to the data, freeing it on destruction.

2. Fix bounds check: name(i) now uses .at(i) for bounds safety.

3. Matrix dimensionality: acknowledged as TODO for Phase 3;
   added comment documenting the limitation.

4. dd/qd generateScalarTypeId branches: these were intentionally
   removed due to posit1/posit2 trait header conflicts when
   number_systems.hpp is included. The typed_datafile path works
   because the client includes the correct type headers. The
   branches will be added when the trait conflict is resolved.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

153 of 207 new or added lines in 3 files covered. (73.91%)

43841 of 52113 relevant lines covered (84.13%)

6046805.51 hits per line