zalando-incubator / kube-ingress-aws-controller / 23140570246

71%

push

github

feat: Add support for NLB target group attributes (ProxyProtocolV2, PreserveClientIP) (#783)

Add support for NLB target group attributes (ProxyProtocolV2, PreserveClientIP)
This change adds support for configuring two NLB-specific target group attributes:

1. Proxy Protocol v2: Enable with `--nlb-proxy-protocol-v2` flag (default: false)
   - Enables Proxy Protocol v2 for NLB target groups
   - Opt-in feature, disabled by default

2. Preserve Client IP: Configure with `--nlb-preserve-client-ip` flag (default: true)
   - Preserves client IP address in NLB target group connections
   - Enabled by default

These attributes are only applied to Network Load Balancer target groups and do not
affect Application Load Balancers.

BREAKING CHANGE:

The `preserve_client_ip` attribute is now explicitly set to true by the controller
on all NLB target groups. Previously, this attribute was not explicitly set, which
relied on AWS NLB's default behavior (which is also true).

If your NLB target groups currently have `preserve_client_ip=false` set outside of
the controller, updating to this version will override it to true. To maintain the
previous behavior of `preserve_client_ip=false`, pass the `--nlb-preserve-client-ip=false`
flag when running the controller.

Changes:
- Add NLB attribute flags to controller CLI
- Extend AWS adapter with WithNLBProxyProtocolV2() and WithNLBPreserveClientIP() methods
- Update CloudFormation template generation to conditionally add NLB attributes
- Add comprehensive test coverage (5 test cases)
- Update README with v0.20 upgrade notes and breaking change documentation

Signed-off-by: speruri <surya.srikar.peruri@zalando.de>

23 of 37 new or added lines in 3 files covered. (62.16%)

2910 of 4072 relevant lines covered (71.46%)

11.98 hits per line