NVIDIA / holodeck / 23139181555

48%

Build Type

push

github

Committed by web-flow

Commit Message

feat: wire cluster networking — private subnets, NAT, hostForNode, real tests (#728)

* feat: wire cluster networking into CreateCluster flow

Connect existing networking functions (public subnet, public route table,
NAT gateway, private route table) into the CreateCluster() sequence.
Instances in cluster mode no longer get public IPs (private subnet behind
NAT GW), and the NLB is placed in the public subnet for internet-facing
access.

- Add createPublicSubnet, createPublicRouteTable, createNATGateway,
  createPrivateRouteTable calls between route table and security group
  phases in CreateCluster
- Change NLB subnet from cache.Subnetid to cache.PublicSubnetid
- Set AssociatePublicIpAddress to false for cluster instances
- Add cluster_test.go with tests for networking order, NLB subnet
  binding, and instance public IP behavior

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: simplify cluster tests to avoid waiter timeout

Rewrite cluster_test.go to use focused unit tests instead of full
CreateCluster integration tests. The InstanceRunningWaiter can't be
easily mocked and causes 5-minute timeouts per test. Also fix
HighAvailabilityConfig -> HAConfig type name.

Signed-off-by: Eduardo Aguilar <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: address Copilot review — remove duplicate route table, use hostForNode, add real tests

1. Remove orphaned createRouteTable() call in cluster mode — private subnet
   gets NAT-routed table from createPrivateRouteTable(), public subnet gets
   IGW-routed table from createPublicRouteTable(). The old call created an
   unused IGW table for the private subnet.

2. Complete hostForNode migration in GetClusterHealth — match nodes by both
   PublicIP and PrivateIP so SSM transport nodes (no public IP) are found.
   GetClusterHealthFromEnv falls back to PrivateIP when PublicIP is empty.

3. Replace trivial compile-time checks with 6 behavioral m... (continued)

Run Details

1 of 54 new or added lines in 3 files covered. (1.85%)

1 existing line in 1 file now uncovered.

3637 of 6511 relevant lines covered (55.86%)

0.62 hits per line