stillwater-sc / universal / 23114576915

84%

master: 84%

Build Type

push

github

Committed by web-flow

Commit Message

feat(posit): implement parse(), fix to_triple/color_print, remove bitblock dep (#562)

* feat(posit): implement parse() and fix to_triple, color_print, type_tag

Add parse() function for posit that handles both posit hex format
(nbits.esxHEXVALUEp) and decimal floating-point strings. This enables
the operator>> istream extraction that was already calling parse()
but had no implementation.

Also in this commit:
- Fix to_triple() to handle NaR/zero explicitly using decoded field
  scales instead of calling scale(number) which bypasses NaR handling
- Move NaR display verification tests from api.cpp to manipulators.cpp
- Remove last bitblock dependency (convert_to_bitblock -> setbits)
- Replace typeid(bt).name() with type_tag(bt{}) in posit and
  blocktriple type_tag() for portable, readable type names

Relates to #559

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(posit): address CodeRabbit review on parse() regex and label typo

- Widen posit hex format regex to support multi-digit es values
  (\\d+ instead of single-digit character class)
- Fix comma-vs-period typo in ReportValue label string

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix(posit): harden parse() against UB shifts and trailing junk

Address two CodeRabbit findings on parse():

1. Posit hex format parsing: tighten regex to [0-9A-Fa-f] (was \w
   which accepts underscores), validate nbits_in and es_in match
   template parameters (eliminates UB shift >= 64), check hex parse
   success and full consumption.

2. Decimal float parsing: reject trailing junk by verifying EOF after
   consuming whitespace (e.g. "1.25abc" was silently accepted as 1.25).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Coverage Stats

48 of 52 new or added lines in 3 files covered. (92.31%)

4 existing lines in 2 files now uncovered.

42993 of 51179 relevant lines covered (84.01%)

6061621.28 hits per line