chideat / valkey-operator / 23088180437

22%

main: 22%

Build Type

Pull #66

github

Committed by chideat

Commit Message

fix: use SHUTDOWN NOSAVE when dbsize is 0 to prevent data loss during cross-version rolling upgrade

During a rolling upgrade (e.g. 7.2 → 9.0), a node demoted to replica may attempt
a fullsync from the new-version master. If the RDB format is incompatible, the load
fails after memory has already been cleared, leaving an empty in-memory state.
A subsequent SHUTDOWN (with save) would then overwrite the valid dump.rdb with empty data.

Fix: re-check Dbsize right before SHUTDOWN. If 0, use SHUTDOWN NOSAVE to preserve the
existing dump.rdb (which holds valid pre-upgrade data). If >0, use normal SHUTDOWN.

Applies to both failover/sentinel and cluster shutdown paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Pull Request Pull Request #66: fix: prevent data loss during cross-version rolling upgrade

Run Details

0 of 26 new or added lines in 2 files covered. (0.0%)

2 existing lines in 1 file now uncovered.

4591 of 20604 relevant lines covered (22.28%)

0.26 hits per line