chideat / valkey-operator / 23088168983
22%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 146
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 22.302% (+2.9%) from 19.354%
23088168983

push

github

web-flow 
Enhanced Stability, Pause Logic, and Sentinel Improvements (#59)

* fix: correct IsPodAnnotationDiff function name in RDS controllers

- Update function call from IsPodAnnonationDiff to IsPodAnnotationDiff
- Maintain all other resource cleanup and finalizer functionality

* refactor: major service comparison and actor improvements

- Add comprehensive IsServiceChanged function for detailed service comparison
- Refactor actor ensure resource ordering and method names
- Improve service change detection with proper label/annotation comparison
- Enhance statefulset handling with better error checking
- Add utility functions for service port and spec comparison

* fix: try meed failed cluster nodes

* feat: Refactor annotation merging for restart annotation

Refactored the annotation merging logic to specifically handle the `RestartAnnotationKey`.

- Introduced `MergeRestartAnnotation` to compare and merge restart annotations based on timestamps.
- Replaced the generic `MergeAnnotations` function with the new specialized function.
- Ensured that the restart annotation is correctly propagated during updates.

* feat: set pause status after all pods deleted

* feat: Improve pause logic and increase sentinel startup probe delay

- Modified the pause logic in the cluster, failover, and sentinel controllers to requeue the resource if nodes still exist, allowing them to scale down gracefully. The operator will now pause reconciliation only after all pods have been terminated.
- Increased the initial delay for the sentinel startup probe to 30 seconds to prevent premature failures on slower systems.

* fix: clean dumplicate resource settings

* fix: fix bug of config update when do redis version update

* fix: added support of force failover to force the sentinel refresh the nodes announce

* Update helper commands and initialization scripts

- Modified cluster, failover, and sentinel command implementations
- Updated initialization scripts for different deploymen... (continued)

245 of 1118 new or added lines in 42 files covered. (21.91%)

59 existing lines in 11 files now uncovered.

4591 of 20586 relevant lines covered (22.3%)

0.26 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.0
 0.0% internal/valkey/node.go
2
3.13
 3.13% internal/ops/failover/actor/actor_heal_pod.go
2
50.91
 50.91% pkg/kubernetes/clientset/service.go
3
9.42
 -0.07% cmd/helper/commands/failover/shutdown.go
3
79.28
 -1.85% internal/builder/clusterbuilder/configmap.go
3
3.66
 3.66% internal/ops/sentinel/actor/actor_heal_monitor.go
4
0.0
 0.0% cmd/helper/commands/cluster/command.go
4
0.0
 0.0% cmd/helper/commands/failover/command.go
4
0.0
 0.0% cmd/helper/commands/helper.go
4
0.0
 0.0% cmd/helper/commands/sentinel/command.go
5
0.0
 0.0% internal/builder/failoverbuilder/configmap.go
5
3.03
 -0.03% internal/ops/cluster/actor/actor_heal_pod.go
5
2.91
 2.91% internal/ops/sentinel/actor/actor_heal_pod.go
6
0.61
 0.03% internal/ops/cluster/actor/actor_ensure_resource.go
6
0.0
 0.0% internal/ops/sentinel/engine.go
7
81.25
 -7.79% internal/config/env.go
9
1.02
 1.02% internal/ops/failover/actor/actor_heal_monitor.go
13
0.0
 0.0% internal/controller/rds/valkey/cluster.go
13
9.85
 -0.15% internal/controller/rds/valkey_controller.go
13
0.0
 0.0% internal/valkey/sentinel/sentinel.go
15
0.0
 0.0% internal/controller/rds/valkey/failover.go
15
26.57
 -0.6% internal/ops/cluster/engine.go
16
0.0
 0.0% internal/ops/failover/engine.go
17
0.0
 0.0% internal/valkey/failover/failover.go
19
0.0
 0.0% cmd/helper/commands/failover/access.go
19
0.0
 0.0% cmd/helper/commands/sentinel/access.go
19
64.84
 64.84% internal/ops/failover/actor/actor_update_config.go
19
94.79
 -4.76% internal/util/kubernetes.go
20
0.0
 0.0% cmd/helper/commands/cluster/access.go
21
0.0
 0.0% internal/valkey/cluster/cluster.go
21
0.0
 0.0% internal/valkey/failover/monitor/sentinel_monitor.go
22
84.43
 -15.57% internal/builder/helper.go
31
1.32
 -0.17% internal/ops/cluster/actor/actor_ensure_slots.go
37
13.41
 -21.47% internal/controller/cluster_controller.go
37
8.33
 -35.57% internal/controller/failover_controller.go
55
14.21
 -4.03% internal/controller/user_controller.go
63
3.19
 -0.56% internal/ops/cluster/actor/actor_update_config.go
139
6.7
 6.7% internal/ops/sentinel/actor/actor_ensure_resource.go
176
7.01
 7.01% internal/ops/failover/actor/actor_ensure_resource.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% cmd/helper/commands/failover/access.go
1
26.57
 -0.6% internal/ops/cluster/engine.go
1
64.84
 64.84% internal/ops/failover/actor/actor_update_config.go
2
9.85
 -0.15% internal/controller/rds/valkey_controller.go
2
14.21
 -4.03% internal/controller/user_controller.go
2
6.7
 6.7% internal/ops/sentinel/actor/actor_ensure_resource.go
3
7.01
 7.01% internal/ops/failover/actor/actor_ensure_resource.go
4
84.43
 -15.57% internal/builder/helper.go
4
3.19
 -0.56% internal/ops/cluster/actor/actor_update_config.go
9
13.41
 -21.47% internal/controller/cluster_controller.go
30
8.33
 -35.57% internal/controller/failover_controller.go
Jobs
ID Job ID Ran Files Coverage
1 23088168983.1 146
22.3
 GitHub Action Run
Source Files on build 23088168983