• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

NVIDIA / holodeck / 23083001272
48%

Build:
DEFAULT BRANCH: main
Ran 14 Mar 2026 07:12AM UTC
Jobs 1
Files 38
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

14 Mar 2026 07:08AM UTC coverage: 53.921% (+0.2%) from 53.753%
23083001272

push

github

web-flow
feat: cleanup dual security groups on cluster delete (#726)

* feat: cleanup dual security groups on cluster delete

Delete flow handles both CP and Worker security groups. Worker SG
deleted before CP SG to respect reference dependency. Empty SG IDs
handled gracefully for single-node backward compatibility.

IAM instance profile cleanup deferred to Wave 3 (no IAM client yet).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: add dedup guard for shared SG same as CP SG on delete

When SecurityGroupid == CPSecurityGroupid (single-node clusters that
reuse the CP SG as shared), skip the redundant shared SG delete to
prevent a double-delete error. Add test for this edge case.

Signed-off-by: Eduardo Aguilar <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

---------

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Eduardo Aguilar <eduardoa@nvidia.com>

20 of 32 new or added lines in 1 file covered. (62.5%)

1 existing line in 1 file now uncovered.

3493 of 6478 relevant lines covered (53.92%)

0.6 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
12
48.62
1.74% pkg/provider/aws/delete.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
48.62
1.74% pkg/provider/aws/delete.go
Jobs
ID Job ID Ran Files Coverage
1 23083001272.1 14 Mar 2026 07:12AM UTC 38
53.92
GitHub Action Run
Source Files on build 23083001272
  • Tree
  • List 38
  • Changed 2
  • Source Changed 1
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #23083001272
  • 223a6345 on github
  • Prev Build on main (#23082973500)
  • Next Build on main (#23084003403)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc