NVIDIA / holodeck / 23083001272

48%

Build Type

push

github

Committed by web-flow

Commit Message

feat: cleanup dual security groups on cluster delete (#726)

* feat: cleanup dual security groups on cluster delete

Delete flow handles both CP and Worker security groups. Worker SG
deleted before CP SG to respect reference dependency. Empty SG IDs
handled gracefully for single-node backward compatibility.

IAM instance profile cleanup deferred to Wave 3 (no IAM client yet).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: add dedup guard for shared SG same as CP SG on delete

When SecurityGroupid == CPSecurityGroupid (single-node clusters that
reuse the CP SG as shared), skip the redundant shared SG delete to
prevent a double-delete error. Add test for this edge case.

Signed-off-by: Eduardo Aguilar <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

---------

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Eduardo Aguilar <eduardoa@nvidia.com>

Run Details

20 of 32 new or added lines in 1 file covered. (62.5%)

1 existing line in 1 file now uncovered.

3493 of 6478 relevant lines covered (53.92%)

0.6 hits per line