agama-project / agama / 23059819960

77%

push

github

Hotfix for an error reporting whether TPM-based unlocking is available (#3279)

## Problem

As reported at
[bsc#1258486](https://bugzilla.suse.com/show_bug.cgi?id=1258486), the
web UI is not displaying the corresponding checkbox to configure TPM
unlocking when the system supports it.

Inspecting the root of the problem, we found the backend was reporting
the string "tpm_fde" to describe the corresponding encryption method,
instead of the correct string "tpmFde".

The investigation also concluded we have a small mess regarding the ids
for the different encryption methods.

## Solution

This pull request fixes the main problem.

It also simplifies the current schema for the system API, removing
values that are actually never reported by the backend.

## Future

The topic needs some more love for the following Agama release. 

On the one hand, we concluded that `availableMethods` should not be part
of the system API. Since it only serves the UI, it should reside in the
private API.

We also need to fix the formats of the encryption method ids to not mix
camelCase and snake_case. But keeping backwards compatibility where
needed.

The code added on this pull request will very likely change in the short
term to adapt to those changes.

## Testing

Tested manually.

3218 of 5102 branches covered (63.07%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

20529 of 25550 relevant lines covered (80.35%)

84.81 hits per line