benwbrum / fromthepage / 23012704593

69%

push

github

Sanitize uploaded PDF filenames before processing to prevent silent extraction failures (#5348)

* Initial plan

* Sanitize PDF filenames with spaces or long names before processing

PDFs with spaces in names or too-long names caused 'Upload processing
complete - no images found'. Add ImageHelper.sanitize_filename that
replaces whitespace and problematic characters with underscores and
truncates base names longer than 100 characters. Use it in process_batch
when writing the uploaded file to the temp directory.

Co-authored-by: saracarl <708566+saracarl@users.noreply.github.com>

* Add test for apostrophe/comma filename: Town_Clerk's case

The apostrophe in filenames like "1850-1910_Town_Clerk's_Miscellaneous_Records,_Book_1.pdf"
breaks the Ghostscript single-quoted output path. The sanitize_filename fix
already handles this by replacing ' and , with underscores. Add explicit test
to cover this case.

Co-authored-by: saracarl <708566+saracarl@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: saracarl <708566+saracarl@users.noreply.github.com>

2320 of 3897 branches covered (59.53%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

9700 of 13471 relevant lines covered (72.01%)

141.24 hits per line