kobotoolbox / kpi / 23009486282

82%

master: 76%

push

github

fix(map): display correct results when filtering map DEV-1446 DEV-1555 DEV-1553 DEV-1564 (#6679)

### 📣 Summary
Fixes the map display to show only submissions from the selected
question

### 💭 Notes
To save myself the time of reiterating every discovery from the time I
started working on this I'll leave a link to the zulip discussion:

https://chat.kobotoolbox.org/#narrow/channel/7-Product/topic/Map.20view.2C.20and.20harmfulness.20of.20.60_geolocation.60/near/783626

https://chat.kobotoolbox.org/#narrow/channel/7-Product/topic/Map.20view.2C.20and.20harmfulness.20of.20.60_geolocation.60/near/793770

This PR fixes 4 bugs (and therefore has many preview steps to check)
because it removes the frontend dependency on `_geolocation` caused
multiple issues.

### 👀 Preview steps

**It may be clearer to follow the reproduction steps outlined in the
respective linear tasks as it comes with a survey and a detailed
explanation of the issue, but the following steps should also work**

1. ℹ️ have an account and **create a new project** (this step is
important to ensure steps 6. and 7. go as planned)
2. create 2 distinct geopoint questions, let's call them question A and
question B
3. create 3 submissions, all 3 answering question A and **only** one
submission answering question B
-- to make some later steps more clear, answer question A with points
very close together, like clicking on the name of a city for example
5. Navigate to the map data display
6. Click in the settings cog
7. 🔴 [on main] notice that the modal doesn't have any radio buttons
selected by default
8. 🟢 [on PR] notice that the modal has the first question selected by
default (DEV-1553)
9. Select **question A** and save
7. 🔴 [on main] notice that saving the modal does nothing on first save,
and another one is required to actually update the points
8. 🟢 [on PR] notice that clicking "Save" once updates the points
immediately (DEV-1564)
11. Do step 8 again
6. 🔴 [on main] notice that the points have com... (continued)

7535 of 11642 branches covered (64.72%)

28964 of 35306 relevant lines covered (82.04%)

5.81 hits per line