agama-project / agama / 23000586689

64%

master: 77%

Build Type

push

github

Committed by web-flow

Commit Message

bsc#1259485: handle nil user passwords when importing from AutoYaST (#3266)


## Problem

[bsc#1259485](https://bugzilla.suse.com/show_bug.cgi?id=1259458)

## Solution

* Properly handle nil user passwords.
* Improve backend errors representation.

<details>
<summary>Before</summary>

```
# agama config generate erb.xml
Backend call failed with status 400 and text '{"error":"agama-autoyast did not produce \"/tmp/autoyastexaBYw/autoinst.json\": No such file or directory (os error 2)"}'
```
</details>

<details>
<summary>Now in case of error (this error does not happen anymore, but
it would look like this)</summary>

```
Backend responded with code 400 and the following message:

"Failed to convert the AutoYaST profile: Could not write the Agama configuration:
/usr/lib64/ruby/gems/3.4.0/gems/agama-yast-17.devel350.11998276e/lib/agama/commands/agama_autoyast.rb:95:in 'Agama::Commands::AgamaAutoYaST#write_agama_config': Agama::Commands::CouldNotWriteAgamaConfig (Agama::Commands::CouldNotWriteAgamaConfig)
\tfrom /usr/lib64/ruby/gems/3.4.0/gems/agama-yast-17.devel350.11998276e/lib/agama/commands/agama_autoyast.rb:57:in 'Agama::Commands::AgamaAutoYaST#run'
\tfrom /usr/lib64/ruby/gems/3.4.0/gems/agama-yast-17.devel350.11998276e/bin/agama-autoyast:49:in '<top (required)>'
\tfrom /usr/bin/agama-autoyast:25:in 'Kernel#load'
\tfrom /usr/bin/agama-autoyast:25:in '<main>'
/usr/lib64/ruby/gems/3.4.0/gems/agama-yast-17.devel350.11998276e/lib/agama/autoyast/root_reader.rb:41:in 'Agama::AutoYaST::RootReader#read': undefined method 'value' for nil (NoMethodError)

        hsh = { \"password\" => root_user.password.value.to_s }
                                                ^^^^^^
\tfrom /usr/lib64/ruby/gems/3.4.0/gems/agama-yast-17.devel350.11998276e/lib/agama/autoyast/converter.rb:61:in 'Agama::AutoYaST::Converter#to_agama'
\tfrom /usr/lib64/ruby/gems/3.4.0/gems/agama-yast-17.devel350.11998276e/lib/agama/commands/agama_autoyast.rb:88:in 'Agama::Commands::AgamaAutoYaST... (continued)

Run Details

2228 of 4007 branches covered (55.6%)

Branch coverage included in aggregate %.

0 of 24 new or added lines in 4 files covered. (0.0%)

1 existing line in 1 file now uncovered.

14262 of 26361 relevant lines covered (54.1%)

44.82 hits per line