ruby-grape / grape / 22996141473

97%

master: 97%

Build Type

Pull #2657

github

Committed by ericproulx

Commit Message

Instantiate validators at definition time

Validators are now instantiated once at route definition time rather than per-request, eliminating repeated allocation overhead. Validator instances are frozen via `DeepFreeze` to make them safe for sharing across requests.

- Override `Validators::Base.new` to call `freeze` after initialization
- Add `Grape::Util::DeepFreeze` to recursively freeze Hash/Array/String values while leaving Procs, scopes, and coercers unfrozen
- Remove `ValidatorFactory` (no longer needed)
- Update all validators to be compatible with frozen instances (move any mutable state out of instance variables set at validation time)
- Add specs for `DeepFreeze`, `SameAsValidator`, and `ExceptValuesValidator`

Pull Request Pull Request #2657: Instantiate validators at definition time

Run Details

1078 of 1170 branches covered (92.14%)

Branch coverage included in aggregate %.

149 of 151 new or added lines in 18 files covered. (98.68%)

6 existing lines in 2 files now uncovered.

3377 of 3434 relevant lines covered (98.34%)

33307.81 hits per line