cybertec-postgresql / pgwatch / 22968679160

83%

push

github

[*] improve log parser, closes #1295 (#1294)

* Update the logparser to return error on invalid configs

`NewLogParser()` will return an error if `logging_collector`
is disabled or `csvlog` is not in `log_destination`

* Update postgres docker images to enable `logging_collector`

- Also use `csvlog` as the log destination
- Grant execute privilege on `pg_read_file(text, bigint, bigint)` for `pgwatch` user

* Update logparsing docs

* Make linter happy

* Make config properties boolean

- fix naming, remove extra log prefixes
- use `MustCompile()` for constant regex
- consistently return errors without logging
- inline `LogConfig`
- fix query to determine log settings

---------

Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>

48 of 52 new or added lines in 3 files covered. (92.31%)

4550 of 5475 relevant lines covered (83.11%)

0.95 hits per line