cybertec-postgresql / pgwatch
86%

DEFAULT BRANCH: master
Repo Added
Token ejuh6e6AAfSXPIriQzeASMY4rzhL8zukh regen
Build 1722 Last
Files 46
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH master
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 86.472% (+0.4%) from 86.085%
30320966560

push

github

web-flow 
[*] migrate to time-only partitioning in pg sink (#1408)

* [*] remove partitionMapMetricDbname map and simplify EnsureMetricDbnameTime to EnsureMetricTimePartsExist

* [*] rename ensure_partition_metric_dbname_time to ensure_partition_metric_time and simplify to 2-level partitioning

* [-] remove drop_source_partitions function as dbname-level partitioning is removed

* [*] update README to reflect metric-time schema instead of metric-dbname-time

* [*] update partition tests to use metric-time schema (2-level partitioning)

* Implement the migration from LIST-partitioned metric to RANGE

Metrics tables created by older versions used LIST partitioning on the dbname
column. Since we now only use RANGE partitioning by time, we need to detect and
drop any LIST-partitioned table so the standard logic can recreate it with
the new partitioning strategy.

* Fix test

* rename migration

* simplify condition

* more test fixes

* Change `--partition-interval`'s default to `1 day`

* Use `admin.drop_all_metric_tables()` in the migration

instead of the old drop-on-write behaviour

* Preserve metric data during time-only partitioning migration

* add missing `FROM` keyword

* use `tx` instead of `conn` and make sure row is always returned

* bump the number of migrations

* try not to mix outer err with in-place err just in case

* list columns explicitly for future reference

* make `suffix` a const instead of reintroducing it at each iteration

* use explicit internal var for error in `BeginFunc`

* use one multi-statement query instead of several `tx.Exec` calls

* define consts for sql queries for easy reading

* use one multi-statement query instead of several `tx.Exec` calls

* add test case for migration

* handle identifiers safely

* Continue directly after finding an already migrated table

Instead of sending 2 additional unecessary queries.

---------

Co-authored-by: Pavlo Golub <pavlo.golub@gmail.com>

97 of 116 new or added lines in 1 file covered. (83.62%)

6 existing lines in 2 files now uncovered.

4775 of 5522 relevant lines covered (86.47%)

0.99 hits per line

Relevant lines Covered
5522 RELEVANT LINES 4775 COVERED LINES
0.99 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30320966560 master [*] migrate to time-only partitioning in pg sink (#1408) * [*] remove partitionMapMetricDbname map and simplify EnsureMetricDbnameTime to EnsureMetricTimePartsExist * [*] rename ensure_partition_metric_dbname_time to ensure_partition_metric_time... push web-flow github
86.47
30320457446 simplify-pg-partitioing-scheme Merge afe6c0b64 into 8755986b8 Pull #1408 web-flow github
86.54
30236274381 dependabot/go_modules/github.com/prometheus/client_golang-1.24.1 Merge 6925af338 into 8755986b8 Pull #1473 web-flow github
85.94
30099724138 master [+] bump `go.etcd.io/etcd/client/v3` from 3.7.0 to 3.7.1 (#1472) Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.7.0 to 3.7.1. - [Release notes](https://github.com/etcd-io/etcd/releases) - [Commits](https://github.com/et... push web-flow github
86.09
30065977294 dependabot/go_modules/go.etcd.io/etcd/client/v3-3.7.1 Merge a55b82324 into 88da04ebe Pull #1472 web-flow github
86.01
30010010505 simplify-pg-partitioing-scheme Merge af6c9c10e into 88da04ebe Pull #1408 web-flow github
86.54
30002783922 simplify-pg-partitioing-scheme Merge 3eaed07f8 into 88da04ebe Pull #1408 web-flow github
84.89
30001454897 simplify-pg-partitioing-scheme Merge 48c3eca07 into 88da04ebe Pull #1408 web-flow github
85.09
30000786493 simplify-pg-partitioing-scheme Merge bb1a32da1 into 88da04ebe Pull #1408 web-flow github
84.92
30000528018 simplify-pg-partitioing-scheme Merge af7b29658 into 88da04ebe Pull #1408 web-flow github
85.04
See All Builds (1716)