zwave-js / zwave-js-ui / 22964763574

18%

push

github

fix(api): enable manual entry for values with allowed ranges (#4588)

Z-Wave JS v15.21.0 changed the value metadata format for values like
`wakeUpInterval` to include both `states` (named options: "Default",
"Disabled") and `allowed` (range entries: `{ from: 300, to: 86400, step:
60 }`). The UI rendered these as a simple dropdown with no manual entry
because `allowManualEntry` was undefined for non-Configuration CC
values.

### Changes

- In `_updateValueMetadata`, when processing values with `states`, check
if `allowManualEntry` is undefined and `allowed` contains range entries
(objects with `from`/`to`)
- If so, default `allowManualEntry` to `true`, enabling the combobox UI
that allows both dropdown selection and custom value entry

```typescript
if (
    valueId.allowManualEntry === undefined &&
    valueId.allowed?.some((entry) => 'from' in entry && 'to' in entry)
) {
    valueId.allowManualEntry = true
}
```

This restores the ability to enter custom wake up intervals (and similar
values) within the allowed range while preserving the named preset
options.

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Unable to change wakeUpInterval value to anything except
Default or Disabled</issue_title>
> <issue_description>### Checklist
> 
> - [x] I am not using Home Assistant. Or: a developer has told me to
come here.
> - [x] I have checked the troubleshooting section and my problem is not
described there.
> - [x] I have read the changelog and my problem is not mentioned there.
> 
> ### Deploy method
> 
> NPM
> 
> ### Z-Wave JS UI version
> 
> 11.14.0
> 
> ### ZwaveJS version
> 
> 15.21.1
> 
> ### Describe the bug
> 
> I am unable to change the wake up interval value for a battery device
except for Default and Disabled:
> 
> <img width="1402" height="453" alt="Image"
src="https://github.com/user-attachments/assets/a7fc6... (continued)

334 of 444 branches covered (75.23%)

Branch coverage included in aggregate %.

0 of 14 new or added lines in 1 file covered. (0.0%)

4054 of 23538 relevant lines covered (17.22%)

1.07 hits per line