hyperledger / fabric-x-committer / 22962577713
90%

DEFAULT BRANCH: main
Ran
Jobs 2
Files 122
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.735% (+0.06%) from 89.678%
22962577713

push

github

web-flow 
[dependency] upgrade to latest stable postgres (#423)

#### Type of change

- Improvement (improvement to code, performance, etc)
 
#### Description

 **Summary**

- Switch PostgreSQL test containers from reusing YugabyteDB's
yugabyte/yugabyte credentials to PostgreSQL's native
  postgres/postgres defaults
- Fix TLS certificate permission issues that prevented tests from
passing on Docker Desktop and Podman Desktop
  (macOS/Windows)
- Fix race condition in the SSL enforcement script caused by PostgreSQL
18's changed PGDATA layout and two-phase startup

  **PostgreSQL 18 Changes That Drove This**

PostgreSQL 18 changed the default PGDATA directory from
/var/lib/postgresql/data to /var/lib/postgresql/<major>/docker (e.g.
/var/lib/postgresql/18/docker). This broke hardcoded paths in the SSL
enforcement script. Additionally, PostgreSQL 18 Alpine images no longer
create the Unix socket at the default port during initdb, causing psql
commands that rely on socket-based connections to fail during the
entrypoint's two-phase startup (temp server on port 5432, real server on
the configured port).

  **Changes**

  _1. Native PostgreSQL credentials (postgres/postgres)_

Previously, PostgreSQL containers reused YugabyteDB's yugabyte/yugabyte
credentials via POSTGRES_USER=yugabyte. This caused a race condition:
the PG Docker entrypoint creates custom users/databases after initdb,
but pg_hba.conf readiness checks could trigger before that step
completed, leading to FATAL: database "yugabyte" does not exist.

The postgres user and database always exist immediately after initdb
(they are PostgreSQL built-ins), eliminating the race entirely.
testdb.NewConnection() now accepts a dbType parameter and returns the
correct default credentials for each database engine.

POSTGRES_USER is omitted from the environment because postgres is
PostgreSQL's built-in default superuser — the Docker image defaults to
postgres when the variable is not set.

  _2. TLS certificate entrypoin... (continued)

9415 of 10492 relevant lines covered (89.74%)

1.31 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
75.51
 -1.02% utils/deliver/deliver_cft.go
4
95.24
 -3.17% mock/coordinator.go
4
93.59
 -0.43% service/vc/validator_committer_service.go
Jobs
ID Job ID Ran Files Coverage
1 unit-test - 22962577713.1 78
68.68
 GitHub Action Run
2 db-test - 22962577713.2 122
83.29
 GitHub Action Run
Source Files on build 22962577713