RobotWebTools / rclnodejs / 22938894213

86%

push

github

Align clang-format include ordering with cpplint rules (#1428)

Previously, clang-format's default Google style IncludeCategories assigned the same priority to C++ standard library headers (e.g., <string>) and third-party headers (e.g., <rcpputils/scope_exit.hpp>), causing them to be sorted alphabetically within the same group. This violated cpplint's expected include order (C system → C++ system → other), requiring `// NOLINTNEXTLINE` comments as workarounds.

Changes:
- .clang-format: Add explicit IncludeCategories to separate C++ standard library headers (no slash, no extension) from third-party angle-bracket headers, and set IncludeBlocks to Regroup so clang-format enforces proper grouping
- .clang-format: Upgrade Standard from Cpp11 to c++17 to match binding.gyp
- Remove `// NOLINTNEXTLINE` from 4 source files: src/rcl_context_bindings.cpp, src/rcl_graph_bindings.cpp, src/rcl_subscription_bindings.cpp, src/rcl_utilities.cpp

Verified with `npm run format` and `npm run lint` (cpplint: 0 errors).

Fix: #1427

1403 of 1770 branches covered (79.27%)

Branch coverage included in aggregate %.

2876 of 3209 relevant lines covered (89.62%)

449.75 hits per line