kubeovn / kube-ovn / 22908941186

23%

master: 23%

push

github

fix: scope SLR deletion to its own VPC to avoid deleting VIPs across VPCs (#6391)

* fix: scope SLR deletion to its own VPC to avoid deleting VIPs across VPCs

When multiple SwitchLBRules in different VPCs share the same VIP IP,
deleting one SLR would incorrectly delete all LBHCs and VIPs matching
that IP across all VPCs. This fix reads the VPC annotation from the
SLR's service, collects the VPC's LB names, and scopes all LBHC
operations to only affect load balancers belonging to the correct VPC.

Fixes #6390

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix: address review feedback - VPC annotation fallback, error handling, and e2e fixes

- Read LogicalRouterAnnotation as fallback when VpcAnnotation is not yet
  set by the endpoint_slice controller
- Explicitly handle vpcsLister.Get errors: requeue on transient errors,
  warn and fall back on NotFound
- Skip e2e test for IPv6-only environments (health checks are IPv4-only)
- Fix VIP wait logic to use WaitUntil (tolerates NotFound during polling)
  instead of WaitToBeReady which fails immediately if VIP doesn't exist

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix: preserve shared LBHCs referenced by other VPCs

When an LBHC is referenced by LBs in multiple VPCs (same VIP IP:port),
only delete it after removing our VPC's reference if no other VPC's LBs
still reference it. This prevents breaking health checks in other VPCs
that share the same LBHC.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

0 of 59 new or added lines in 1 file covered. (0.0%)

12395 of 54054 relevant lines covered (22.93%)

0.27 hits per line