ArduPilot / MethodicConfigurator / 22879097084

93%

push

github

ci(pytest): fix SITL cache key to avoid per-run bloat and redundant downloads

The previous cache key used github.run_id, which is unique per workflow
run. This caused a cache miss every run, followed by a new cache save,
bloating the GitHub Actions cache and eventually evicting useful entries.
The SITL binary was still restored via the restore-keys fallback, but a
new cache entry was written on every run.

Fix by:
- Adding a 'Compute SITL cache key' step that derives a stable
  YYYY-QN key from the current date, matching the quarter-based
  download logic already present in the script
- Using SITL_CACHE_KEY as the exact cache key, giving exact hits for
  the entire quarter and writing only one new cache entry per quarter
- Caching sitl/ directly instead of sitl-cache/, eliminating the
  intermediate directory and the cp step
- Narrowing restore-keys to sitl-cache-ubuntu- to avoid restoring a
  binary built for a different architecture
- Simplifying the download step to check for sitl/arducopter directly,
  removing the now-unnecessary sitl-cache/<CACHE_KEY>/ subdirectory
  indirection

3270 of 3470 branches covered (94.24%)

21526 of 23375 relevant lines covered (92.09%)

1.38 hits per line