kobotoolbox / kpi / 22857255360

82%

master: 76%

push

github

fix(formBuilder): ensure cloned choices and rows ids are unique DEV-1759 (#6740)

### 📣 Summary

When cloning a question in Form Builder the result is now ensured to be
a copy with unique ids. Previously clone was using original row ids
leading to unexpected behaviour.

### 💭 Notes

The problem was happening for every cloned row. The `$kuid` was being
cloned too. Luckily we don't rely on `$kuid` much, but it is an obvious
error that could be potentially problematic.

The visible issue was happening for cloning of few types: `select_one`,
`select_multiple`, `rank` or `score`. When cloning such row, code was
also cloning the list of choices for it. Before the fix the cloned list
of choices was wrongly being synced between two rows (the original and
the clone). This leads to confusing issues as the syncing isn't obvious
and might get unnoticed and lead to unwanted changes in the form.

Changes in this PR:
- In `clone` function of choices list
(`jsapp/xlform/src/model.choices.coffee`), I ensure that the unique ids
are stripped and regenerated - for the list itself and for each option.
I also register the new list in global list of `choices`
- In `clone` (look for `rr.clone`) function of `ScoreRankMixin`
(`jsapp/xlform/src/model.row.coffee`) I similarly ensure unique ids are
stripped and regenerated - for the row itself and for the score/rank
levels
- In `clone` function of `row.Row` (`jsapp/xlform/src/model.row.coffee`)
I introduced safety measure to ensure unique properties are not being
copied and `select_one` and `select_multiple` are properly copying only
non-unique things
- Added one `TODO` comment for a weird single use `_isCloned` flag
- Added comment about us purposefuly not allowing `kobomatrix` cloning
(as I thought initially it was a mistake/bug)
- Some minor code readability improvements (coffee syntax is not nice)
- Added some comments here and there :) 

### 👀 Preview steps

I recommend this setup:
- Create new empty form and save (unselect ... (continued)

7536 of 11616 branches covered (64.88%)

28926 of 35224 relevant lines covered (82.12%)

1.62 hits per line