RobotWebTools / rclnodejs / 22839244476

86%

push

github

Fix Node creation crash when using plain object as options (#1424)

When a plain object (e.g., `{ enableRosout: false }`) is passed as options instead of a `NodeOptions` instance, `options.parameterOverrides` is `undefined`, causing `TypeError: Cannot read properties of undefined (reading 'length')`.

Added `Node._normalizeOptions()` to merge plain objects with `NodeOptions.defaultOptions` defaults using nullish coalescing (`??`), ensuring all documented defaults are preserved for unspecified fields while respecting explicitly set values (including `false`).

**Files:**
- `lib/node.js` — added `static _normalizeOptions()`, called at the top of `_init()`
- `test/test-node.js` — added tests for node creation with plain object options and empty object options

Fix: #1423

1404 of 1770 branches covered (79.32%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

2876 of 3209 relevant lines covered (89.62%)

460.85 hits per line