• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

iotaledger / iota / 22834743110
65%

Build:
DEFAULT BRANCH: develop
Ran 09 Mar 2026 04:10AM UTC
Jobs 1
Files 1540
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Mar 2026 08:35PM UTC coverage: 63.868% (+0.002%) from 63.866%
22834743110

push

github

web-flow
fix(starfish): increase per-block lock limit in header synchronizer to prevent peer starvation (#10532)

# Description of change

Increase `MAX_AUTHORITIES_TO_FETCH_PER_BLOCK_HEADER` from 2 to 3 to fix
header synchronizer starvation when wiped-DB validators saturate
per-block lock slots. `MAX_PERIODIC_SYNC_PEERS` stays at 4.

**Observed Problem in testing:** When 3 validators have wiped DBs and
their blocks are garbage collected and referenced by a certified commit,
the block suspender marks them as "who knows" peers. The header
synchronizer then selects 2 of them as known peers (filling
`MAX_PERIODIC_SYNC_PEERS - MAX_PERIODIC_SYNC_RANDOM_PEERS = 4 - 2 = 2`
slots). With `MAX_AUTHORITIES_TO_FETCH_PER_BLOCK_HEADER = 2`, these 2
known peers saturate all per-block lock slots, blocking random peers
from fetching. Since wiped validators always fail, the system is stuck.

**Fix:** Increase `MAX_AUTHORITIES_TO_FETCH_PER_BLOCK_HEADER` from 2 to
3, allowing 3 concurrent fetchers per block header. Even when both known
peers are wiped-DB validators occupying 2 lock slots, 1 slot remains for
a random peer to reach a healthy validator. This preserves the original
peer count (4) while resolving the starvation.

## Links to any relevant issues

Fixes #10531

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] I have added tests that prove my fix is effective or that my
feature works: I run the same simulation scenario in which some
validator got stuck and were not able to get synced
- [x] I have checked that new and existing unit tests pass locally with
my changes

64 of 66 new or added lines in 1 file covered. (96.97%)

88 existing lines in 14 files now uncovered.

227289 of 355874 relevant lines covered (63.87%)

2762094.25 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
91.6
0.0% crates/starfish/core/src/header_synchronizer.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
83.78
-2.7% crates/iota-cluster-test/src/test_case/native_transfer_test.rs
1
96.69
-0.55% crates/iota-core/src/checkpoints/causal_order.rs
1
86.76
-0.13% crates/iota-network/src/discovery/mod.rs
1
97.92
-1.04% crates/iota-surfer/src/surfer_task.rs
2
94.92
-0.25% crates/iota-core/src/consensus_adapter.rs
3
89.44
-1.67% crates/iota-surfer/src/surfer_state.rs
4
83.42
-0.43% crates/starfish/core/src/commit_syncer/fast.rs
5
82.73
-4.55% crates/iota-surfer/src/surf_strategy.rs
5
64.55
-1.22% crates/starfish/core/src/commit_syncer/mod.rs
6
91.67
-0.43% crates/starfish/core/src/authority_node.rs
6
81.32
-1.17% crates/starfish/core/src/network/tonic_network.rs
7
67.14
-10.0% crates/iota-types/src/execution_status.rs
12
93.03
-2.09% crates/iota-core/src/congestion_tracker.rs
34
91.6
0.0% crates/starfish/core/src/header_synchronizer.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 22834743110.1 09 Mar 2026 04:10AM UTC 1552
63.61
GitHub Action Run
Source Files on build 22834743110
  • Tree
  • List 1540
  • Changed 40
  • Source Changed 0
  • Coverage Changed 40
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #22834743110
  • 1fe8c43d on github
  • Prev Build on develop (#22811352372)
  • Next Build on develop (#22882922530)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc