f-dangel / curvlinops / 22827494237

91%

push

github

[DEL] Replace MC-Fisher with MC-sampling option in GGN (#255)

* [ADD,DEL,REF] MC-sampling on GGNLinearOperator, remove FisherMCLinearOperator (#255)

Add `mc_samples` parameter to `GGNLinearOperator` and unify the MC interface
across `GGNDiagonalLinearOperator`/`GGNDiagonalComputer` (replacing `mode`).
Remove `FisherMCLinearOperator` and `curvlinops/fisher.py`. Move shared GGN
utilities (loss Hessian, sampling) from `kfac_utils.py` to new `ggn_utils.py`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* [DOC] Extend GGN docstrings to explain MC approximation via loss Hessian square root

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Felix Dangel <fdangel@Felixs-MacBook-Pro.local>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: f-dangel <felix.dangel@concordia.ca>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

149 of 153 new or added lines in 5 files covered. (97.39%)

2205 of 2416 relevant lines covered (91.27%)

0.91 hits per line