agama-project / agama / 22767455106

77%

push

github

Allow to reuse LVM volume groups, volumes and thin pools (#3210)

## Problem

Agama does not allow to reuse an existing LVM volume group and its
logical volumes.

## Solution

This adds the possibility to search and, thus, reuse existing volume
groups and its logical volumes.

Includes the possibility to create normal volumes, thin pools and thin
volumes.

It also includes the possibility to create new thin volumes in a reused
thin pool.

It allows to specify which logical volumes should be deleted and resized
in order to make space for the new logical volume, in a way totally
analogous to what can already be done with partitions when using a disk.

It also allows to add more physical volumes to an existing volume group.
But only using explicit volumes (ie. physical volumes cannot be created
on demand using `generate`).

Apart from shrinking pre-existing logical volumes, this also allows to
grow them in a similar way that what can be done for partitions.

## See also

This depends on https://github.com/yast/yast-storage-ng/pull/1421

## Testing

- Added unit tests, but they cannot pass until
https://github.com/yast/yast-storage-ng/pull/1421 is merged
- Tested manually

## To do (follow-ups)

- Detect possible incorrect settings or setups and detect them in the
`ConfigChecker`.
- More criteria for searching logical volumes, like searching by volume
name or by volume type (normal, pool, thin, etc.).
- Decide whether the proposal should refuse to resize some logical
volumes and partitions to prevent unexpected data loss (that is a
general topic not really related to LVM).

3162 of 5184 branches covered (61.0%)

Branch coverage included in aggregate %.

132 of 132 new or added lines in 22 files covered. (100.0%)

20739 of 26205 relevant lines covered (79.14%)

81.83 hits per line