zwave-js / zwave-js-ui / 22755858891

18%

push

github

fix(ui): fix background RSSI chart showing blank on second open (#4576)

Opening the controller's background RSSI fullscreen dialog a second time
renders a blank chart.

The root cause was that on the second open, the async component module
is already cached and renders synchronously — so `create()` runs before
browser layout, reading `offsetWidth = 0` and creating an invisible
0-width chart with no recovery path.
  Fixes in `BgRssiChart.vue`:  
- `create()`: if `container.offsetWidth === 0` at mount time, defer
chart creation by 50ms so layout has time to settle
- `setSize()`: when `fillSize=true`, use viewport height directly
instead of `container.offsetHeight`, preventing a ResizeObserver
feedback loop that would silently shrink the chart to nothing

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Opening the Controller's background RSSI chart twice does
not work</issue_title>
> <issue_description>### Checklist
> 
> - [ ] I am not using Home Assistant. Or: a developer has told me to
come here.
> - [ ] I have checked the troubleshooting section and my problem is not
described there.
> - [ ] I have read the changelog and my problem is not mentioned there.
> 
> ### Deploy method
> 
> Manually built (git clone - npm run build - npm install
> 
> ### Z-Wave JS UI version
> 
> master branch, 2025-03-05
> 
> ### ZwaveJS version
> 
> not relevant
> 
> ### Describe the bug
> 
> When opening the network map and clicking the controller node, a
dialog opens with the background RSSI chart.
> After closing that dialog and opening it again, the RSSI chart is
broken and shows no data:
> 
> <img width="539" height="961" alt="Image"
src="https://github.com/user-attachments/assets/dd76086d-f39e-4fe0-8e8c-9e0fa3880aa2"
/>
> 
> ### To Reproduce
> 
> see above
> 
> ### Expected behavior
> 
> it should not be broken
> 
> ### Additional ... (continued)

334 of 444 branches covered (75.23%)

Branch coverage included in aggregate %.

4054 of 23524 relevant lines covered (17.23%)

1.07 hits per line