stacklok / toolhive / 22754465418

64%

Build Type

push

github

Committed by web-flow

Commit Message

MCPRemoteProxy: Surface validation errors via Events and Status Conditions (#4024)

* Improve MCPRemoteProxy error reporting with events and status conditions

Add pre-deployment validation to the MCPRemoteProxy controller that
emits Kubernetes Events and sets a ConfigurationValid status condition
when configuration errors are detected. This replaces the previous
behavior where users had to inspect pod logs to understand why their
proxy was in CrashLoopBackOff.

Validations added:
- OIDC issuer URL scheme (HTTP vs HTTPS) with insecureAllowHTTP support
- Cedar authorization policy syntax checking
- Referenced authz ConfigMap existence and key validation
- Referenced header Secret existence validation

Closes #2289

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Reduce scope to OIDC issuer URL validation only

Remove authz policy syntax validation, ConfigMap/Secret reference
checks, and header secret validation to keep the PR focused on
foundation code (EventRecorder, ConfigurationValid condition,
validation pattern) that can be extended later.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add integration tests for Kubernetes Event emission

Test that validation failures emit Warning events (visible via
kubectl describe) and that successful validations do not emit
spurious warning events.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Run Details

57 of 65 new or added lines in 3 files covered. (87.69%)

7 existing lines in 4 files now uncovered.

46860 of 73458 relevant lines covered (63.79%)

75.84 hits per line