RobotWebTools / rclnodejs / 22749886344

86%

push

github

Fix: correct bugs in test files (#1418)

### Summary

Fixed 6 bugs across 6 test files discovered during code review. All issues were in test code only — no library changes.

### Changes

#### 1. `test/client_setup.js` — Remove reference to undefined `timer`

The `SIGINT` handler called `timer.cancel()`, but `timer` is not defined in this scope. Removed the call to prevent a `ReferenceError` if the signal is received.

#### 2. `test/test-lifecycle.js` — Fix duplicate transition index

Two consecutive assertions both checked `transitions[1]`, meaning `transitions[2]` was never validated. Changed the second check from `transitions[1]` to `transitions[2]`.

#### 3. `test/test-parameter-service.js` — Fix wrong parameter name

`Parameter.fromParameterMessage` was called with `name: 'p1'` but the test was validating parameter `A.p3`. Changed to `name: 'A.p3'`.

#### 4. `test/test-rate.js` — Add missing assertion

The test computed an average sleep time but never asserted on it. Added an assertion that the average is within 5x the expected period.

#### 5. `test/test-utils.js` — Remove empty duplicate test

An empty test body `it('should valid ensureDirSync works correctly', function () {})` duplicated the immediately following test `it('should verify ensureDirSync works correctly', ...)`. Removed the empty duplicate.

#### 6. `test/types/index.test-d.ts` — Remove misplaced type assertion

`expectType<boolean>(client.isServiceServerAvailable())` was in the **ActionClient** section but tested `client` (the service client variable). The same assertion already exists in the correct Client section. Removed the misplaced copy.

### Files changed

| File | Change |
|------|--------|
| `test/client_setup.js` | Remove undefined `timer.cancel()` |
| `test/test-lifecycle.js` | `transitions[1]` → `transitions[2]` in second assertion |
| `test/test-parameter-service.js` | `'p1'` → `'A.p3'` |
| `test/test-rate.js` | Add avg sleep time assertion |
| `test/test-utils.js` |... (continued)

1388 of 1756 branches covered (79.04%)

Branch coverage included in aggregate %.

2869 of 3204 relevant lines covered (89.54%)

475.58 hits per line