openwallet-foundation / acapy-vc-authn-oidc / 22741628705

91%

push

github

No Longer Preserve Records and Rely On Debug-Webhooks (#980)

* No Longer Preserve Records and Rely On Debug-Webhooks

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

* Refactor acapy_handler and tests

- Updated messages in `_cleanup__connection` for clarity: replaced "connection has been verified" with "abandonment" and "expiration".
- Removed outdated tests for presentation deletion on states 'done', 'abandoned', and 'declined' from `test_acapy_handler.py` to streamline the test suite.
- Eliminated tests related to handling deletion failures and retrieval failures, which are no longer relevant to the updated logic.
- Cleaned up code in `test_acapy_handler_cleanup.py` for clarity and maintainability.

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

* Refactor and Enhance Tests for Connection-Based Verification Webhooks

- Removed skipping of the `test_present_proof_webhook_sends_problem_report_on_expired_state` test and clarified its logic regarding expired sessions.
- Improved handling of expired connections by ensuring `send_problem_report` and `delete_connection` functionalities are properly asserted.
- Added a new test `test_cleanup_connection_logs_failure_when_delete_returns_false` to verify behavior when connection deletion fails.
- Introduced a new test class `TestMiscWebhookCoverage` with tests for unknown topics and a successful connection webhook path to enhance code coverage.
- Added exception handling tests to `_extract_credential_schemas` and `_extract_issuer_dids` to ensure robustness in data extraction methods.

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

---------

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

12 of 12 new or added lines in 1 file covered. (100.0%)

2458 of 2724 relevant lines covered (90.23%)

0.9 hits per line