openwallet-foundation / acapy-vc-authn-oidc / 22600858259

91%

Build Type

push

github

Committed by web-flow

Commit Message

Replace requests with httpx for async HTTP                                                                                                                                                        (#971)

* Refactor AcapyClient to Use httpx and Improve Async Handling

- Replaced `requests` with `httpx` for asynchronous HTTP client capabilities.
- Updated AcapyClient methods to be asynchronous and adjusted their signatures.
- Enhanced error handling for API calls and improved logging.
- Optimized cleanup functions to ensure non-blocking execution.
- Updated unit tests to mock `httpx` responses and configure async behavior.
- Ensured compatibility with new async patterns across the codebase, including startup registration and webhook handling.

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

* Add unit tests for ACAPY client methods

This commit introduces comprehensive unit tests for the ACAPY client, focusing on the `delete_connection` and `get_connections_batched` methods.
- The tests for `delete_connection` cover handling of network errors and timeouts.
- The `get_connections_batched` tests address various scenarios including empty results, pagination with single and multiple pages, and error handling for network issues and non-200 responses.

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

* Format and drop requests-mock as it is nolonger needed

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

* Add configurable HTTP request timeout for ACA-Py

- Introduced `ACAPY_REQUEST_TIMEOUT` setting in `config.py` to allow customization of the HTTP request timeout for ACA-Py requests, defaulting to 10 seconds.
- Updated `main.py` to utilize the new configuration for setting the timeout of the HTTP client.

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>

* Enhance cleanup functionality to support dry-run mode

- Updated cleanup logic to allow for a dry-run mode, enabling users to see what records wou... (continued)

Run Details

169 of 179 new or added lines in 9 files covered. (94.41%)

9 existing lines in 2 files now uncovered.

2458 of 2744 relevant lines covered (89.58%)

0.9 hits per line