hyperledger / fabric-x-committer / 22704208289

90%

main: 90%

Build Type

Pull #316

github

Committed by cendhu

Commit Message

Address review comments

To support the fuzz contract:
- extractField now returns the last match for duplicate fields, matching
  proto3's last-writer-wins semantics for scalar fields. Note that proto.Marshal
  would not add duplicate fields but proto.Unmarshal parses them correctly even
  if there are duplicate fields.
- Remove the "advance past field 1" optimization in ChannelHeader parsing
  since last-writer-wins requires searching from the beginning for each field.
  Example bytes (field order): field5, field1, field5, field1
  - Last field 1 is at position 4. Advancing past it means we only search positions 5+ for field 5.
  - But the last field 5 is at position 3 — we'd miss it.

Signed-off-by: Senthilnathan <cendhu@gmail.com>

fix all bugs

Signed-off-by: Senthilnathan <cendhu@gmail.com>

Pull Request Pull Request #316: Introduce UnmarshalEnvelopeLite to speed up mapBlock

Run Details

122 of 151 new or added lines in 3 files covered. (80.79%)

14 existing lines in 6 files now uncovered.

9487 of 10584 relevant lines covered (89.64%)

1.34 hits per line