decentraland / social-service-ea / 22675218654

90%

push

github

fix: resolve RPC subscription generator memory leak (#389)

* fix: add destroy() method and valueQueue cap to emitterToGenerator

Adds a synchronous destroy() for external termination of the async
generator, and caps valueQueue at 1000 to prevent unbounded buffering.

* fix: track and destroy generators on subscriber removal

Registers active generators per subscriber and calls destroy() on all
of them before clearing emitter handlers, breaking the cleanup deadlock.

* fix: register/unregister generators in handleSubscriptionUpdates

Ensures every emitterToAsyncGenerator instance is tracked from creation
to cleanup so the subscriber context can destroy them on disconnect.

* fix: deduplicate cleanup logic and remove dead code in generator lifecycle

- Delegate return() to destroy() to avoid duplicated cleanup logic
- Add valueQueue clearing in throw() for consistency with destroy()
- Remove unreachable cleanup function after finally block in handleSubscriptionUpdates
- Replace timeout-based test with deterministic consume-then-destroy approach

* fix: add clarifying comments and improve finally block ordering

- Add TODO for MAX_VALUE_QUEUE_SIZE to calibrate from production metrics
- Document silent event drops with TODO for future metrics/logging
- Clarify why throw() does not delegate to destroy()
- Swap finally block to call return() before unregisterGenerator()

2159 of 2536 branches covered (85.13%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 3 files covered. (100.0%)

5280 of 5727 relevant lines covered (92.19%)

71.69 hits per line