zwave-js / zwave-js-ui / 22675305577
18%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 70
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 19.044% (-0.004%) from 19.048%
22675305577

push

github

web-flow 
feat(ui): add confirmation dialog for destructive configuration parameters (#4572)

Z-Wave config parameters can be marked `destructive` (e.g., factory
reset commands) — setting them remotely may leave the device needing
physical intervention to recover. The UI should gate writes on these
parameters behind an explicit user confirmation.

## Changes

- **`api/lib/ZwaveClient.ts`**
  - Added `destructive?: boolean` to `ZUIValueId` type
- Propagate `ConfigurationMetadata.destructive` into the value model in
`_updateValueMetadata`

- **`src/components/nodes-table/ExpandedNode.vue`**
- In `updateValue()`, check `v.destructive` and show an `alert`-level
confirm dialog before proceeding with the `writeValue` API call;
cancelling aborts the write cleanly

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Add support for destructive configuration
parameters</issue_title>
> <issue_description>The next driver release will include support for
marking config parameters as destructive. This is exposed using the
`destructive` property on configuration parameter metadata.
> 
> The main use case for this is to have applications ask the user for
confirmation before setting these destructive parameters. A prime
example are factory reset parameters. Those can be set remotely, but the
device will need manual/physical intervention before being usable
again.</issue_description>
> 
> ## Comments on the Issue (you are @copilot in this section)
> 
> <comments>
> <comment_new><author>@robertsLando</author><body>
> OK so if this property is present on a configuration valueID I should
show a confirmation dialog before sending the value, right?
</body></comment_new>
> </comments>
> 


</details>



<!-- START COPILOT CODING AGENT SUFFIX -->

- Fixes zwave-js/zwave-js-ui#4432

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot sma... (continued)

334 of 444 branches covered (75.23%)

Branch coverage included in aggregate %.

0 of 5 new or added lines in 1 file covered. (0.0%)

4052 of 22587 relevant lines covered (17.94%)

1.12 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
5
0.0
 0.0% api/lib/ZwaveClient.ts
Jobs
ID Job ID Ran Files Coverage
1 22675305577.1 70
19.04
 GitHub Action Run
Source Files on build 22675305577