stacklok / toolhive / 22622637559

64%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor session timeouts and add V2 feature warnings (#3974)

Extract hardcoded timeout values in session manager into package-level
constants for better maintainability. Add startup warnings when
SessionManagementV2 is configured with incompatible features.

Changes:
- pkg/transport/session: Extract 5s and 30s timeouts to named constants
  (defaultOperationTimeout and cleanupOperationTimeout) to improve
  readability and make adjustments easier
- pkg/vmcp/server: Warn operators at startup when SessionManagementV2
  is enabled alongside unsupported features (optimizer mode, composite
  tools) to provide early feedback instead of silent feature loss

Addresses PR review feedback from @aponcedeleonch.

Closes: #3866

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Run Details

24 of 36 new or added lines in 2 files covered. (66.67%)

35 existing lines in 4 files now uncovered.

45870 of 72420 relevant lines covered (63.34%)

75.7 hits per line