agama-project / agama / 22620900016

77%

Build Type

push

github

Committed by web-flow

Commit Message

Use D-Bus attributes instead of methods (#3217)

### Problem

The D-Bus API offers methods to get the information (config, system,
proposal, etc). Using methods does not allow to D-Bus proxies to
automatically cache the information. Caching is important to avoid
possible deadlock when the service is blocked (e.g., waiting for a
question to be answered).

https://bugzilla.suse.com/show_bug.cgi?id=1258466

### Solution

Modify the D-Bus API to use attributes instead of methods. 

Note: custom signals like `SystemChanged` or `ProposalChanged` can be
removed because now there is a `PropertiesChanged` signal. For now they
are kept in order to not break the monitors in the rust side.

Run Details

3155 of 5212 branches covered (60.53%)

Branch coverage included in aggregate %.

153 of 172 new or added lines in 3 files covered. (88.95%)

2 existing lines in 2 files now uncovered.

20619 of 26262 relevant lines covered (78.51%)

80.37 hits per line