tired-labs / tiredize / 22608374303

99%

push

github

Issue/sanitize text newline bug (#19)

* Fix sanitize_text trailing newline bug by using split instead of splitlines

splitlines() treats trailing \n as a terminator and drops it, causing
the sanitized output to be shorter than the input. split('\n') treats
it as a separator, preserving the trailing empty element so the output
length matches the input length. Unskips 3 spec tests that were blocked
by this bug.

* Update issue files and parser specification for sanitize_text fix

Promotes sanitize-text-newline-bug to active with resolved design
decisions. Adds CRLF deferral note to gfm-parity. Updates parser
spec to document the split vs splitlines contract.

* Unskip 2 additional sanitize_text tests in test_utils.py

Peer review found 2 more tests skipped for the same splitlines bug
that were not in the original issue tally. Both pass with the fix.

* Remove stale splitlines bug comment from test_table_sanitize_idempotent

The comment described the splitlines trailing newline bug as a known
gap, but the bug is now fixed.

* Add edge case tests for multiple and all-newline sanitize_text matches

Covers acceptance criterion 4: match ending with multiple trailing
newlines and match consisting entirely of newline characters.

* Mark sanitize-text-newline-bug as completed

11 of 11 new or added lines in 2 files covered. (100.0%)

4607 of 4859 relevant lines covered (94.81%)

1.9 hits per line