JuliaLang / julia / 1595

77%

master: 77%

push

buildkite

SharedArrays: Skip a `finally` step if we throw before the `shmmem_create_pid` local is defined (#61141)

In theory, if we throw on line 116 (e.g. if `getpid()` or `randstring()`
throws), then we'll enter the `finally` block before we ever define
`shmmem_create_pid`. I think this case is unlikely, but if we do hit it,
we can't perform the `remotecall_fetch` call in the `finally` block,
because `shmmem_create_pid` won't be defined.

So this PR checks if `shmmem_create_pid` is defined before doing the
`remotecall_fetch` call.

Alternatively, we could lift lines 116 and 117 out of the `try` block,
at which point it will no longer be possible (as far as I can tell) for
us to throw before defining `shmmem_create_pid`.

---

Detected by JET.

1 of 1 new or added line in 1 file covered. (100.0%)

63470 of 82620 relevant lines covered (76.82%)

23642030.47 hits per line