• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ruby-grape / grape / 22525040970
97%
master: 97%

Build:
Build:
LAST BUILD BRANCH: revisit_validators
DEFAULT BRANCH: master
Ran 28 Feb 2026 05:03PM UTC
Jobs 37
Files 155
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

28 Feb 2026 05:02PM UTC coverage: 96.743% (-0.1%) from 96.875%
22525040970

Pull #2657

github

ericproulx
Instantiate validators at definition time and fix thread safety

Validator instantiation at definition time:
- Store validator instances in ParamsScope/ContractScope and have
  Endpoint#run_validators read them directly
- Remove ValidatorFactory indirection and eagerly compute validator
  messages/options in constructors
- Freeze validator instances after initialization via Base.new to
  prevent mutation across shared requests (shallow freeze)
- Extract Grape::Util::Translation module shared by Exceptions::Base
  and Validators::Base for I18n translate with fallback locale
- Support Hash messages in translate_message for deferred translation
  with interpolation parameters (e.g. { key: :length, min: 2 })
- Normalize Grape::Exceptions::Validation params handling and refactor
  validator specs to define routes per example group
- Use case/when for message_key extraction in Exceptions::Validation
- Guard LengthValidator against missing constraints and extract option
  validation into private methods to stay within complexity limits
- Store zero-arity procs directly in ValuesValidator (consistent with
  ExceptValuesValidator) and document DB-backed lazy evaluation intent
- Drop test-prof dependency and its spec config

Thread safety for shared ParamsScope instances:
- Introduce Grape::Validations::ScopeTracker to hold all per-request
  mutable state (array index and qualifying params) in a single
  Thread.current entry, keeping shared ParamsScope objects immutable
- ScopeTracker.track { } wraps the validation run in Endpoint and
  ensures cleanup via ensure regardless of errors
- AttributesIterator stores current array indices via ScopeTracker
  instead of mutating @index on the shared scope
- ParamsScope#full_name reads the current index from ScopeTracker
  instead of @index; remove @index, reset_index, and attr_accessor
- meets_dependency? stores qualifying array params in ScopeTracker
  instead of @params_meeting_dependency on the shared scope
- Change... (continued)
Pull Request #2657: Instantiate validators at definition time

1079 of 1171 branches covered (92.14%)

Branch coverage included in aggregate %.

231 of 234 new or added lines in 27 files covered. (98.72%)

3377 of 3435 relevant lines covered (98.31%)

39111.62 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
91.67
-4.33% lib/grape/exceptions/base.rb
1
78.26
-9.24% lib/grape/exceptions/validation.rb
1
95.77
-0.14% lib/grape/validations/validators/base.rb
Jobs
ID Job ID Ran Files Coverage
1 run-3.4-gemfiles/rails_7_2.gemfile - 22525040970.1 28 Feb 2026 05:03PM UTC 155
95.61
GitHub Action Run
2 run-4.0-gemfiles/rails_7_2.gemfile - 22525040970.2 28 Feb 2026 05:04PM UTC 155
95.61
GitHub Action Run
3 run-3.4-gemfiles/rack_3_1.gemfile - 22525040970.3 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
4 run-3.4-gemfiles/rails_8_1.gemfile - 22525040970.4 28 Feb 2026 05:04PM UTC 155
95.61
GitHub Action Run
5 run-3.4-gemfiles/rack_3_0.gemfile - 22525040970.5 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
6 run-3.3-gemfiles/rails_8_0.gemfile - 22525040970.6 28 Feb 2026 05:03PM UTC 155
95.61
GitHub Action Run
7 run-3.2-gemfiles/rails_7_2.gemfile - 22525040970.7 28 Feb 2026 05:03PM UTC 155
95.65
GitHub Action Run
8 run-4.0-gemfiles/rails_8_1.gemfile - 22525040970.8 28 Feb 2026 05:04PM UTC 155
95.61
GitHub Action Run
9 run-3.3-gemfiles/rack_2_2.gemfile - 22525040970.9 28 Feb 2026 05:04PM UTC 154
95.56
GitHub Action Run
10 run-3.2-gemfiles/rack_3_0.gemfile - 22525040970.10 28 Feb 2026 05:03PM UTC 154
95.65
GitHub Action Run
11 run-4.0-gemfiles/multi_xml.gemfile - 22525040970.11 28 Feb 2026 05:03PM UTC 154
35.22
GitHub Action Run
12 run-3.3-Gemfile - 22525040970.12 28 Feb 2026 05:03PM UTC 154
95.6
GitHub Action Run
13 run-3.2-gemfiles/rack_3_1.gemfile - 22525040970.13 28 Feb 2026 05:03PM UTC 154
95.65
GitHub Action Run
14 run-3.4-gemfiles/rack_3_2.gemfile - 22525040970.14 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
15 run-3.3-gemfiles/rack_3_0.gemfile - 22525040970.15 28 Feb 2026 05:03PM UTC 154
95.6
GitHub Action Run
16 run-4.0-gemfiles/rack_3_0.gemfile - 22525040970.16 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
17 run-4.0-Gemfile - 22525040970.17 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
18 run-4.0-gemfiles/rack_2_2.gemfile - 22525040970.18 28 Feb 2026 05:04PM UTC 154
95.56
GitHub Action Run
19 run-3.3-gemfiles/rack_3_1.gemfile - 22525040970.19 28 Feb 2026 05:03PM UTC 154
95.6
GitHub Action Run
20 run-4.0-gemfiles/rack_3_1.gemfile - 22525040970.20 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
21 run-4.0-gemfiles/multi_json.gemfile - 22525040970.21 28 Feb 2026 05:03PM UTC 154
35.22
GitHub Action Run
22 run-3.2-Gemfile - 22525040970.22 28 Feb 2026 05:03PM UTC 154
95.65
GitHub Action Run
23 run-3.2-gemfiles/rack_2_2.gemfile - 22525040970.23 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
24 run-4.0-gemfiles/hashie.gemfile - 22525040970.24 28 Feb 2026 05:04PM UTC 154
61.3
GitHub Action Run
25 run-3.2-gemfiles/rails_8_1.gemfile - 22525040970.25 28 Feb 2026 05:03PM UTC 155
95.65
GitHub Action Run
26 run-3.2-gemfiles/rails_8_0.gemfile - 22525040970.26 28 Feb 2026 05:03PM UTC 155
95.65
GitHub Action Run
27 run-3.3-gemfiles/rails_8_1.gemfile - 22525040970.27 28 Feb 2026 05:03PM UTC 155
95.61
GitHub Action Run
28 run-3.2-gemfiles/rack_3_2.gemfile - 22525040970.28 28 Feb 2026 05:03PM UTC 154
95.65
GitHub Action Run
29 run-4.0-gemfiles/grape_entity.gemfile - 22525040970.29 28 Feb 2026 05:03PM UTC 154
48.68
GitHub Action Run
30 run-4.0-gemfiles/rack_3_2.gemfile - 22525040970.30 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
31 run-3.4-gemfiles/rails_8_0.gemfile - 22525040970.31 28 Feb 2026 05:03PM UTC 155
95.61
GitHub Action Run
32 run-4.0-gemfiles/rails_8_0.gemfile - 22525040970.32 28 Feb 2026 05:04PM UTC 155
95.61
GitHub Action Run
33 run-4.0-gemfiles/dry_validation.gemfile - 22525040970.33 28 Feb 2026 05:03PM UTC 154
56.93
GitHub Action Run
34 run-3.3-gemfiles/rails_7_2.gemfile - 22525040970.34 28 Feb 2026 05:04PM UTC 155
95.61
GitHub Action Run
35 run-3.3-gemfiles/rack_3_2.gemfile - 22525040970.35 28 Feb 2026 05:03PM UTC 154
95.6
GitHub Action Run
36 run-3.4-gemfiles/rack_2_2.gemfile - 22525040970.36 28 Feb 2026 05:03PM UTC 154
95.56
GitHub Action Run
37 run-3.4-Gemfile - 22525040970.37 28 Feb 2026 05:03PM UTC 154
95.61
GitHub Action Run
Source Files on build 22525040970
  • Tree
  • List 155
  • Changed 27
  • Source Changed 25
  • Coverage Changed 23
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #22525040970
  • Pull Request #2657
  • PR Base - master (#22524001785)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc