pomerium / pomerium / 22368105628
45%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 676
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 44.549% (+0.06%) from 44.487%
22368105628

push

github

web-flow 
feat: schema-based blob chunking for resume uploads (#6138)

## Summary

This PR implements the storage layer primitives to perform immutable
writes of data with simple in-flight integrity checks for the session
recording API & protocol.

The chunk writer:
- writes metadata in proto and json format (one for querying, one for
human-readability)
- acts as an append only writer for the recording content
- finalizes the recording by persisting a signature (provenance &
integrity) and manifest (chunk metadata for querying & lookup)

It handles several conflict cases that should abort immediately:
- metadata already exists
- chunk gap
- chunks already signed   

The chunk reader:
- Implements some basic iteration over content chunks
- Reads metadata
- Implements size, manifest and last modified primitives for later use
at query time

<hr/>

The PR also implements a conformance suite that can be run against blob
stores that verifies the append-only and immutable behavior end-to-end.

<hr/>

See the issue's linked RFC for more details.

## Related issues


[ENG-3609](https://linear.app/pomerium/issue/ENG-3609/blob-storage-chunked-reading-and-writing)

## User Explanation
N/A

## Checklist

- [X] reference any related issues
- [X] updated unit tests
- [X] add appropriate label (`enhancement`, `bug`, `breaking`,
`dependencies`, `ci`)
- [X] ready for review

227 of 323 new or added lines in 3 files covered. (70.28%)

208 existing lines in 9 files now uncovered.

33129 of 74365 relevant lines covered (44.55%)

117.53 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
46
0.0
 pkg/storage/blob/providers/providers.go
50
78.45
 pkg/storage/blob/chunk.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
75.41
 0.0% pkg/storage/postgres/registry.go
3
87.75
 0.0% config/config_source.go
4
77.03
 -2.7% pkg/grpcutil/client_manager.go
4
88.08
 -0.88% pkg/storage/postgres/postgres.go
7
76.52
 -1.06% pkg/storage/postgres/backend.go
8
91.72
 -1.79% pkg/ssh/policy_index_inmemory.go
9
80.13
 0.0% pkg/ssh/manager.go
83
73.1
 -17.77% internal/mcp/extproc/server.go
89
58.54
 0.17% internal/controlplane/server.go
Jobs
ID Job ID Ran Files Coverage
1 22368105628.1 676
44.55
 GitHub Action Run
Source Files on build 22368105628