dnsimple / erldns / 22316550462

87%

Build Type

push

github

Committed by web-flow

Commit Message

Logging and observability improvements (#332)

* Tiny list processing improvement in the resolver

* Skip logging a TCP killed if we killed it ourselves

* Use async cancel timers for a microscopic performance improvement

* Make connection idle timeout a debug log, less noise

* Make a TCP socket error a notice, as more than info but less than warning

* Make ingress timeout also logged as info, ingress timeouts are not normal

* Use the usual log_metadata helper

* Try to gather information about what query did time out actually

* Give better naming to the tcp pid log

* Log ingress and current timestampts when dropping a package

* Maybe this can be just notice logs, still more than info

The idea is that if we're under load, logging everything will take even
more load away, if an admin didn't configure a wide enough log-level we
might even save the CPU logging from here.

* Create helper boolean filters for more direct and performant common record types

* Add errors on request timeout too

Run Details

40 of 49 new or added lines in 7 files covered. (81.63%)

2 existing lines in 2 files now uncovered.

1708 of 1962 relevant lines covered (87.05%)

1006.99 hits per line