firezone / firezone / 22287984059

62%

Build Type

push

github

Committed by web-flow

Commit Message

fix(phoenix-channel): introduce ephemeral `Connected` state (#12254)

The `PhoenixChannel` component is designed to be stateful in order to
allow for reconnects when the connection fails. Several aspects of its
state however are tied to a particular instance of the connection. For
example, queued "join" messages for a topic only make sense within the
scope of a particular connection. When the WebSocket connection gets
teared down, these need to be cleared.

It is easy to forget to clear this kind of state. To prevent further
bugs in this code, we introduce a dedicated `Connected` state which
holds all pieces of state that are specific to a certain connection. As
soon as we disconnect, the entire `Connected` state is discarded and
only recreated once the connection is reestablished.

Run Details

83 of 99 new or added lines in 4 files covered. (83.84%)

17 existing lines in 9 files now uncovered.

31831 of 51087 relevant lines covered (62.31%)

297615.83 hits per line