firezone / firezone / 22289697444

62%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(snownet): make `IceConfig` connection-specific (#12241)

With the removal of the old (< 1.4.0) connection scheme, we can finally
simplify some of the abstractions in `snownet`. Previously, we had two
types of connections and therefore, we need to access instances of the
`IceAgent` for both types, resulting in an API on our `Connections` type
that didn't return a `Connection` itself but only individual fields. As
a consequence, a lot of functionality around manipulating e.g. the
`IceAgent` was extracted into free-functions because it couldn't live on
any type in particular.

Now that these reasons no longer exist, we can move functionality like
adding and removing `Candidate`s to the `Connection` type itself,
simplifying the overall data flow.

Furhermore, this allows us to implement a feature we will need for
client <> client connectivity: Connection-specific idle timers. Instead
of applying a global ICE timing config for an entire `Node`, we pass
those configs into `upsert_connection`, allowing the caller to decide on
a case-by-case basis, what the timing config for this connection should
be.

To begin with, these values will always be the same but for client <>
client connections, we will change that such that those connections
never idle. Connections between clients are bi-directional and
therefore, we need a more aggressive timeout behaviour to be able to
give earlier feedback to the user in case the remote disappears.

Run Details

263 of 274 new or added lines in 5 files covered. (95.99%)

6 existing lines in 4 files now uncovered.

31854 of 51084 relevant lines covered (62.36%)

299380.4 hits per line